Skip to content

Timestamps and flow control#26

Merged
gregnr merged 2 commits intochipmk:mainfrom
jawj:main
May 5, 2026
Merged

Timestamps and flow control#26
gregnr merged 2 commits intochipmk:mainfrom
jawj:main

Conversation

@jawj
Copy link
Copy Markdown
Contributor

@jawj jawj commented Apr 29, 2026

Claude Code suggested these tiny changes to fix issues I had in getting https://printervention.app to work (I have not dug into this too much, but they seem likely related to #6).

@gregnr
Copy link
Copy Markdown
Member

gregnr commented May 2, 2026

Thanks for the PR @jawj! Your app is fascinating by the way - super cool use case. I need to confirm this change makes sense as defaults for everyone (likely they are), then I'll merge it in.

@gregnr
Copy link
Copy Markdown
Member

gregnr commented May 5, 2026

Alright I pushed a commit with a couple more changes: reverted TCP_MSS to 1460 because it turns out lwIP subtracts timestamp overhead internally, so 1448 caused double subtraction to 1436. I also noticed the receive window could get permanently stuck if a chunk was larger than the remaining desiredSize, so included a fix for that too. Backpressure tests now pass and cover both client-to-server and server-to-client.

Merging this now, thanks again @jawj!

@gregnr gregnr merged commit aec7cd2 into chipmk:main May 5, 2026
1 check passed
@gregnr
Copy link
Copy Markdown
Member

gregnr commented May 6, 2026

This is now released in v0.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants