Skip to content

fix(response-interceptor): reduce responseInterceptor buffer churn#1236

Merged
chimurai merged 2 commits into
masterfrom
improve-response-interceptor
May 21, 2026
Merged

fix(response-interceptor): reduce responseInterceptor buffer churn#1236
chimurai merged 2 commits into
masterfrom
improve-response-interceptor

Conversation

@chimurai
Copy link
Copy Markdown
Owner

@chimurai chimurai commented May 21, 2026

fixes: #929
closes: #1235

Summary by CodeRabbit

  • Bug Fixes

    • Optimized response interceptor buffering to improve performance and reduce overhead
  • Tests

    • Added unit tests verifying response interceptor correctly buffers and concatenates multiple data chunks

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 83547242-0328-4bdf-a2af-2f5677485557

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improve-response-interceptor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chimurai chimurai marked this pull request as ready for review May 21, 2026 21:19
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 21, 2026

npm i https://pkg.pr.new/http-proxy-middleware@1236

commit: c5bd0b4

@chimurai chimurai added this to the v4.1 milestone May 21, 2026
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 94.315% (+0.1%) from 94.18% — improve-response-interceptor into master

@chimurai chimurai merged commit 31429ad into master May 21, 2026
26 checks passed
@chimurai chimurai deleted the improve-response-interceptor branch May 21, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak in function responseInterceptor of file handlers/response-interceptor.ts

2 participants