Added section about passing options to request#24
Open
stylesuxx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you want to pass options to the request call, it is not enough to set them in the options argument, they need to be within the key requestOptions.
Also I think, that the user passed options should be the last ones applied and override anything that is set by the library. Right now the library is overwriting some of the options.
I would suggest setting the user options for requests before the actual call to request:
proxy-verifier/index.js
Line 388 in ff1d21e
I am aware this can break the call - but if the user is passing options to request, I guess he knows what he is doing.
If you like the idea I can submit a PR.