Skip to content

Endowment#169

Merged
jinnykim1208 merged 227 commits intomainfrom
endowment
Apr 6, 2026
Merged

Endowment#169
jinnykim1208 merged 227 commits intomainfrom
endowment

Conversation

@notkarenyi
Copy link
Copy Markdown
Collaborator

@notkarenyi notkarenyi commented Jan 22, 2026

What does this PR do?

How was the functionality tested and verified?

All steps should be completed in the order presented, and you should not move on to the next step until the previous is completed.

  • The title of each visual's html page is the same as the chart title.
  • The meta_data.json file for each visual is filled in correctly (the description is a complete sentence, and the title is the same as the visual).
  • Each visual and associated files has been minified using the npm run process-visual command.
  • Each visual was styled according to style guidelines (centered title/subtitle, uses our color scheme, etc.).
  • Each visual was approved by the lead developer.
  • Each visual was approved by the story's authors and/or stakeholders.
  • Each visual was submitted to Copy, and the resulting comments/edits have been resolved.

@notkarenyi notkarenyi marked this pull request as ready for review April 5, 2026 04:30
@notkarenyi
Copy link
Copy Markdown
Collaborator Author

notkarenyi commented Apr 5, 2026

hello @jinnykim1208 @Nik4002 @emi-ly-sun this has passed copy/print and is ready for data editor review for web publishing when you have the time!

currently not passing the prettier check due to the property story?

I also remember in the past we didn't include the data cleaning python scripts in the repo but not sure if we should include this one for method transparency reasons

@jinnykim1208 jinnykim1208 merged commit da9eb54 into main Apr 6, 2026
1 check failed
@jinnykim1208 jinnykim1208 deleted the endowment branch April 6, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants