Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion .coderabbit.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

tone_instructions: |
You are a concise code reviewer. Focus only on critical logic, security, and performance issues.
You are a concise code reviewer. Focus only on critical logic, security, and performance issues.
Avoid trivial style issues or minor formatting suggestions.

reviews:
Expand All @@ -17,3 +17,41 @@ reviews:
# suppress walkthrough/summary comment when no findings
collapse_walkthrough: true
changed_files_summary: false

# Pre-merge checks
pre_merge_checks:
title:
mode: error
requirements: >
Title must be concise (under 72 characters) and clearly describe the change.
Use imperative mood (e.g. "Fix", "Add", "Update", not "Fixed", "Added", "Updated").
description:
mode: warning
docstrings:
mode: off
custom_checks:
- name: Rebase rules for upstream changes
mode: error
instructions: >
If the PR modifies files under `code/` (excluding `code/extensions/che-*/**`
and `**/package-lock.json`), then the PR MUST also include corresponding
rebase rules in the `.rebase/` directory AND an entry in `.rebase/CHANGELOG.md`.
Comment thread
sbouchet marked this conversation as resolved.

Important:
- A file can be under `code/` and still be Che-only (for example `code/src/.../che/...` newly created by Che). Do not create a rule for such files if they are not upstream VS Code files.
- Still create rules for the upstream file(s) that import/use those Che-only helpers.

The PR template has a checklist section "Does this PR contain changes that
override default upstream Code-OSS behavior?" with three checkboxes. If the
PR touches files under `code/`, all three checkboxes should be checked.

PASS if:
- No files under `code/` are changed (excluding che extensions and lock files), OR
- Newly added Che-only files with no upstream counterpart, OR
- Files under `code/` are changed AND `.rebase/` rules, `.rebase/CHANGELOG.md`,
and `rebase.sh` conflict routing are also updated in the same PR.

FAIL if files under `code/` are changed but any of the following are missing:
- `.rebase/` rule files (add/override/replace as appropriate)
- `.rebase/CHANGELOG.md` entry
- `rebase.sh` routing for the new rule files (e.g. elif branch in resolve_conflicts)
Loading