Conversation
- Set actual version instead of "0.0.0" via ldflags in `Dockerfile` and `.goreleaser.yaml`. - Removed `// TODO: set version` in `cmd/unspeech/main.go`. - Fixed `tsconfig.lib.json doesn't exist` warning in TypeScript SDK build by pointing to `tsconfig.json`. Co-authored-by: chainsaid <127925965+chainsaid@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- `pkg/backend/doubao/voices.go`: Add `//nolint:mnd` to bypass magic number checks for audio sample rates. - `pkg/backend/microsoft/speech.go`: Change `omitempty` to `omitzero` for `mo.Option` fields in JSON structs, per `modernize` rules. - `internal/middlewares/error_handler.go`: Change `make([]slog.Attr, 0)` to `var attrs []slog.Attr` to fix `prealloc` warning. Co-authored-by: chainsaid <127925965+chainsaid@users.noreply.github.com>
- `pkg/backend/doubao/voices.go`: Add `//nolint:mnd` to bypass magic number checks for audio sample rates. - `pkg/backend/microsoft/speech.go`: Change `omitempty` to `omitzero` for `mo.Option` fields in JSON structs, per `modernize` rules. - `internal/middlewares/error_handler.go`: Preallocate slice correctly using `make([]slog.Attr, 0, len(callerAttrs)+1)` to fix `prealloc` warning. Co-authored-by: chainsaid <127925965+chainsaid@users.noreply.github.com>
1 participant
Fixes build warnings and unaddressed TODOs regarding setting the application version during the build process.
PR created automatically by Jules for task 13994062978388834178 started by @chainsaid