Store original video metadata before normalization#1040
Open
Fuitad wants to merge 1 commit intocgwire:mainfrom
Open
Store original video metadata before normalization#1040Fuitad wants to merge 1 commit intocgwire:mainfrom
Fuitad wants to merge 1 commit intocgwire:mainfrom
Conversation
When a movie is uploaded, zou normalizes it to the project's target resolution, then saves the normalized dimensions to the database. This means we lose track of what the user actually uploaded. Now we grab the original width, height, duration and file size from the uploaded file and stash them in the preview_file.data JSONB column before normalization runs. No migration needed since the column already exists. Also added the data field to the playlist entity preview-files API response so the frontend can access it.
Contributor
|
Thank you for your contribution @Fuitad. We'll review this as soon as possible. |
Author
|
Hello @nledez. Just wondering if there's any interest in merging this into the main zou branch. If not (which is fine), we'll start our own branch to be able to incorporate it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a movie is uploaded, zou normalizes it to the project's target resolution, then saves the normalized dimensions to the database. This means we lose track of what the user actually uploaded.
Now we grab the original width, height, duration and file size from the uploaded file and stash them in the preview_file.data JSONB column before normalization runs. No migration needed since the column already exists.
Also added the data field to the playlist entity preview-files API response so the frontend can access it.
Problem
We needed a way to access the size of the original file uploaded. Right now, what is saved in the database in terms of height and width is only what zou re-encodes.
Solution
The original data is saved in the data column of the preview_file table. All existing stuff, no migration, no issue for previous uploads :).