Various fixes

package.json

@@ -46,7 +46,7 @@
     "moment-timezone": "0.6.1",
     "panzoom": "9.4.4",
     "papaparse": "5.5.3",
-    "qrcode.vue": "3.8.0",
+    "qrcode.vue": "3.8.1",
     "sanitize-html": "2.17.2",
     "socket.io-client": "4.8.3",
     "superagent": "10.3.0",
@@ -85,7 +85,7 @@
     "lint-staged": "16.4.0",
     "localStorage": "1.0.4",
     "prettier": "3.8.1",
-    "sass": "1.98.0",
+    "sass": "1.99.0",
     "vite": "8.0.3",
     "vitest": "4.1.2",
     "vitest-localstorage-mock": "0.1.2",

src/App.vue

@@ -1109,9 +1109,12 @@ input.input {
 .select select:active,
 .select select:focus,
 input.input:focus {
-  border-color: #00b242;
+  border-color: $green;
   outline: none;
 }
+.select select:required:invalid {
+  border-color: $red;
+}
 
 .button,
 .button.is-small {

src/components/modals/AddMetadataModal.vue

@@ -287,8 +287,7 @@ export default {
         (['string', 'number', 'boolean'].includes(this.form.data_type) ||
           (['list', 'taglist'].includes(this.form.data_type) &&
             this.form.values.length) ||
-          (this.form.data_type === 'checklist' &&
-            this.checklist?.[0]?.text.length)) &&
+          (this.form.data_type === 'checklist' && this.checklist?.[0]?.text)) &&
         (!this.isCurrentUserSupervisor ||
           !this.user.departments.length ||
           this.form.departments.length)

src/components/modals/EditAssetModal.vue

@@ -25,6 +25,7 @@
           <combobox
             :label="$t('assets.fields.episode')"
             :options="episodeOptions"
+            required
             v-model="form.source_id"
             v-if="isTVShow"
           />
@@ -166,7 +167,7 @@ export default {
       form: {
         name: '',
         description: '',
-        source_id: null,
+        source_id: 'null',
         data: {
           resolution: ''
         },
@@ -276,9 +277,11 @@ export default {
         }
         this.form.name = ''
         this.form.description = ''
-        this.form.source_id = this.currentEpisode
-          ? this.currentEpisode.id
-          : null
+        this.form.source_id =
+          this.currentEpisode &&
+          !['all', 'main'].includes(this.currentEpisode.id)
+            ? this.currentEpisode.id
+            : 'null'
         this.form.data = {}
         this.form.is_shared = 'false'
       } else {
@@ -288,7 +291,8 @@ export default {
           project_id: this.assetToEdit.project_id,
           name: this.assetToEdit.name,
           description: this.assetToEdit.description,
-          source_id: this.assetToEdit.source_id || this.assetToEdit.episode_id,
+          source_id:
+            this.assetToEdit.source_id || this.assetToEdit.episode_id || 'null',
           data:
             {
               ...this.assetToEdit.data,

src/components/modals/EditCommentModal.vue

@@ -297,7 +297,7 @@ export default {
           id: this.commentToEdit.id,
           text: this.form.text,
           task_status_id: this.form.task_status_id,
-          checklist: this.form.checklist.filter(item => item.text.length),
+          checklist: this.form.checklist.filter(item => item.text),
           newAttachmentFiles: this.attachmentFiles,
           attachmentFilesToDelete: this.attachmentFilesToDelete,
           links: this.form.link ? [this.form.link] : null

src/components/modals/EditPersonModal.vue

@@ -33,6 +33,7 @@
           :label="$t('people.fields.email')"
           :disabled="personToEdit.is_generated_from_ldap"
           v-model.trim="form.email"
+          @update:model-value="$emit('reset-error', 'email')"
           v-if="!isBot"
         />
         <text-field
@@ -280,7 +281,7 @@ export default {
     }
   },
 
-  emits: ['cancel'],
+  emits: ['cancel', 'reset-error'],
 
   data() {
     return {

src/components/modals/PreviewModal.vue

@@ -6,23 +6,33 @@
     }"
   >
     <div class="modal-background" @click="$emit('cancel')"></div>
-    <div class="new-window">
-      <a class="mr1" :href="previewDlPath" v-if="previewFileId">
-        <arrow-down-icon />
+    <div class="actions">
+      <a
+        :href="previewDlPath"
+        :title="$t('playlists.actions.download_file')"
+        v-if="previewFileId"
+      >
+        <download-icon />
       </a>
-      <a target="_blank" :href="previewPath">
+      <a
+        :href="previewPath"
+        target="_blank"
+        :title="$t('playlists.actions.see_original_file')"
+      >
         <arrow-up-right-icon />
       </a>
+      <span class="pointer" :title="$t('main.close')" @click="$emit('cancel')">
+        <x-icon />
+      </span>
     </div>
-
     <div class="modal-content" @click="$emit('cancel')">
       <img :src="previewPath" />
     </div>
   </div>
 </template>
 
 <script>
-import { ArrowDownIcon, ArrowUpRightIcon } from 'lucide-vue-next'
+import { ArrowUpRightIcon, DownloadIcon, XIcon } from 'lucide-vue-next'
 
 import { getDownloadAttachmentPath } from '@/lib/path'
 
@@ -34,8 +44,9 @@ export default {
   mixins: [modalMixin],
 
   components: {
-    ArrowDownIcon,
-    ArrowUpRightIcon
+    ArrowUpRightIcon,
+    DownloadIcon,
+    XIcon
   },
 
   props: {
@@ -58,41 +69,42 @@ export default {
   computed: {
     previewPath() {
       if (this.previewFileId) {
-        const id = this.previewFileId
-        return this.active && this.previewFileId
-          ? '/api/pictures/originals/preview-files/' + id + '.png'
+        return this.active
+          ? `/api/pictures/originals/preview-files/${this.previewFileId}.png`
           : ''
-      } else if (this.attachment) {
+      }
+      if (this.attachment) {
         return getDownloadAttachmentPath(this.attachment)
       }
       return ''
     },
 
     previewDlPath() {
-      const previewId = this.previewFileId
-      return `/api/pictures/originals/preview-files/${previewId}/download`
+      return `/api/pictures/originals/preview-files/${this.previewFileId}/download`
     }
   }
 }
 </script>
 
 <style lang="scss" scoped>
-.error {
-  margin-top: 1em;
-}
-
-.new-window {
+.actions {
+  display: inline-flex;
+  gap: 1em;
   color: $grey;
   position: absolute;
   right: 1em;
   top: 1em;
   z-index: 2;
+
+  & > *:hover {
+    color: $light-grey;
+  }
 }
 
 .modal-content {
   width: 100%;
   text-align: center;
-  max-height: 100vh;
+  max-height: 100vmax;
 
   img {
     max-height: 100vh;

src/components/pages/People.vue

@@ -134,6 +134,7 @@
       @confirm="confirmEditPeople"
       @confirm-invite="confirmCreateAndInvite"
       @invite="confirmInvite"
+      @reset-error="resetError"
       v-if="modals.edit"
     />
 
@@ -530,6 +531,12 @@ export default {
         })
     },
 
+    resetError(error) {
+      if (error === 'email') {
+        this.errors.invalidEmailDomain = false
+      }
+    },
+
     onSearchChange() {
       if (this.searchField) {
         const searchQuery = this.searchField?.getValue()

src/components/previews/PreviewPlayer.vue

@@ -1164,7 +1164,7 @@ export default {
     },
 
     focus() {
-      this.$refs.container.focus()
+      this.$refs.container?.focus()
     },
 
     timeCodeClicked({ versionRevision, frame }) {

src/components/widgets/AddComment.vue

@@ -685,7 +685,7 @@ export default {
         attachments = []
         checklist = []
       } else {
-        checklist = checklist.filter(item => item.text.length)
+        checklist = checklist.filter(item => item.text)
       }
 
       revision = Number(revision)

src/components/widgets/Checklist.vue

@@ -37,7 +37,7 @@
         @keyup.backspace="removeChecklistEntry(index)"
         @keyup.up="focusPrevious(index)"
         @keyup.down="focusNext(index)"
-        :disabled="entry.text.length !== 0 && disabled"
+        :disabled="entry.text?.length !== 0 && disabled"
         v-autosize
         v-model.trim="entry.text"
       ></textarea>
@@ -127,7 +127,7 @@ export default {
 
     removeChecklistEntry(index) {
       const entry = this.checklist[index]
-      if (entry.text.length === 0) {
+      if (!entry.text) {
         this.$emit('remove-task', entry)
         this.focusPrevious(index)
       }

src/components/widgets/Combobox.vue

@@ -16,6 +16,7 @@
           }"
           ref="select"
           :disabled="disabled"
+          :required="required && !hasSelectedOption"
           @keyup.enter="emitEnter()"
           @change="updateValue"
         >
@@ -85,6 +86,10 @@ export default {
     isInline: {
       default: false,
       type: Boolean
+    },
+    required: {
+      default: false,
+      type: Boolean
     }
   },
 

src/components/widgets/Comment.vue

@@ -811,7 +811,7 @@ export default {
         this.lastCall = now
         const comment = {
           id: this.comment.id,
-          checklist: this.checklist.filter(item => item.text?.length)
+          checklist: this.checklist.filter(item => item.text)
         }
         this.$emit('checklist-updated', comment)
       }

src/store/modules/tasks.js

@@ -385,9 +385,8 @@ const actions = {
     const selectedTaskIds = Array.from(state.selectedTasks.keys())
     for (const taskId of selectedTaskIds) {
       const task = state.taskMap.get(taskId)
-      const taskType = rootGetters.taskTypeMap.get(task.task_type_id)
-
       if (task && task.priority !== priority) {
+        const taskType = rootGetters.taskTypeMap.get(task.task_type_id)
         const updatedTask = await tasksApi.updateTask(taskId, { priority })
         commit(EDIT_TASK_END, { task: updatedTask, taskType })
       }