Open
Conversation
Contributor
mtkalms
commented
Mar 18, 2026
mtkalms
commented
- Add parameters to adjust how groups of gaps are merged
- Add documentation
- Use named functions where possible - Apply styleguide
rhliang
requested changes
Mar 19, 2026
Contributor
rhliang
left a comment
rhliang
left a comment
There was a problem hiding this comment.
Looks good, just the of -> oof thing (and one minor typo).
ruby/lib/cfe_gotoh.rb
Outdated
| end | ||
|
|
||
| def self.merge_insertions_and_deletions_to_fix_oof_sequences( | ||
| def self.merge_insertions_and_deletions_to_fix_of_sequences( |
Contributor
There was a problem hiding this comment.
oof was correct ("out of frame"). Maybe we could change this to out_of_frame to avoid confusion.
ruby/lib/cfe_gotoh.rb
Outdated
| end | ||
|
|
||
| merge_insertions_and_deletions_to_fix_oof_sequences(standard, query) | ||
| merge_insertions_and_deletions_to_fix_of_sequences(standard, query) |
ruby/lib/cfe_gotoh.rb
Outdated
| else # Choose the larger of the two middle gaps as center | ||
| center = gaps.size / 2 - 1 + max_gap_index(gaps[(gaps.size / 2 - 1), 2]) | ||
| end | ||
| # Compress gaps to the left og the center gap |
Contributor
There was a problem hiding this comment.
Suggested change
| # Compress gaps to the left og the center gap | |
| # Compress gaps to the left of the center gap |
- Fix typos - oof was not a typo - Change oof to out_of_frame
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 232 235 +3
=========================================
+ Hits 232 235 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhliang
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.