Skip to content

Don't ignore sourced workflow files#434

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:dont-ignore
Sep 19, 2025
Merged

Don't ignore sourced workflow files#434
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:dont-ignore

Conversation

@erikgb
Copy link
Copy Markdown
Member

@erikgb erikgb commented Sep 19, 2025

The file patterns ignored by default in the shared Renovate preset have to be unignored here, ref. https://github.com/cert-manager/renovate-config/blob/6b95dd749c240f5d099df5dccb196705c2b3debc/default.json5#L142-L146

I think this PR should make Renovate suggest upgrades inside makefiles-modules modules as well. And avoid manual PRs as #432.

/cc @wallrj @wallrj-cyberark

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow Bot requested a review from wallrj September 19, 2025 11:55
@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Sep 19, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

@erikgb: GitHub didn't allow me to request PR reviews from the following users: wallrj-cyberark.

Note that only cert-manager members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

The file patterns ignored by default in the shared Renovate preset have to be unignored here, ref. https://github.com/cert-manager/renovate-config/blob/6b95dd749c240f5d099df5dccb196705c2b3debc/default.json5#L142-L146

I think this PR should make Renovate suggest upgrades inside makefiles-modules modules as well. And avoid manual PRs as #432.

/cc @wallrj @wallrj-cyberark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2025
@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Sep 19, 2025

/cc @ThatsMrTalbot

@ThatsMrTalbot
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThatsMrTalbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2025
@cert-manager-prow cert-manager-prow Bot merged commit 69cdacf into cert-manager:main Sep 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants