Add a new check-commits CI job using gitlint#1263
Open
phlogistonjohn wants to merge 2 commits intoceph:masterfrom
Open
Add a new check-commits CI job using gitlint#1263phlogistonjohn wants to merge 2 commits intoceph:masterfrom
phlogistonjohn wants to merge 2 commits intoceph:masterfrom
Conversation
phlogistonjohn
added
the
no-API
phlogistonjohn
force-pushed
the
jjm-gitlint
branch
2 times, most recently
from
5c66ac2 to
5c061fc
Compare
phlogistonjohn
changed the title
anoopcs9
reviewed
Apr 30, 2026
| [title-must-not-contain-word] | ||
| # Comma-separated list of words that should not occur in the title. Matching is case | ||
| # insensitive. It's fine if the keyword occurs as part of a larger word (so "WIPING" | ||
| # will not cause a violation, but "WIP: my title" will. |
Collaborator
There was a problem hiding this comment.
missing a closing parenthesis?
Collaborator
Author
There was a problem hiding this comment.
I don't think so, but re-reading the comment I see that wip,WIP is probably redundant because the doc says this is case insensitive.
Collaborator
There was a problem hiding this comment.
I was indicating the only opening parenthesis ( seen here in the comment.
Collaborator
|
Feel free to ignore but pasting the warning I saw from corresponding CI runs: |
phlogistonjohn
force-pushed
the
jjm-gitlint
branch
from
5c061fc to
3f697a6
Compare
Collaborator
Author
Added the option to suppress the warnings. |
Collaborator
Author
|
@Mergifyio rebase |
This will be later used to check commit messages. Signed-off-by: John Mulligan <jmulligan@redhat.com>
This uses the gitlint tool to check for basic formatting of commit messages. In particular we want to require the Signed-off-by on all commits. We were kinda-sorta requiring it but not always enforcing it. ceph/ceph has been requiring it for a long time. I also think it's even more important now that people declare they have the right to contribute change now that more and more tools are being used to generate code. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Contributor
|
Deprecation notice: This pull request comes from a fork and was rebased using |
Contributor
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
jjm-gitlint
branch
from
3f697a6 to
7803e3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new check-commits CI job that uses gitlint to enforce some basic parameters of git commit messages in contributions to go-ceph. In particular we want to require the Signed-off-by on all commits. We were kinda-sorta requiring it but not always enforcing it. ceph/ceph has been requiring it for a long time.
I also think it's even more important now that people declare they have
the right to contribute change now that more and more tools are being
used to generate code.
I've used gitlint in other projects with success so I chose that rather than agonize other available tools.