Raise ValueError for SVG images with zero or missing width#112
Closed
leofernandezg wants to merge 1 commit intocdelker:masterfrom
Closed
Raise ValueError for SVG images with zero or missing width#112leofernandezg wants to merge 1 commit intocdelker:masterfrom
leofernandezg wants to merge 1 commit intocdelker:masterfrom
Conversation
SVG images with width="0" or no width attribute caused ZeroDivisionError at `s = width / imgwidth`. Now raises a clear ValueError instead. Added test/test_svg_image.py. Fixes cdelker#109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorinstead ofZeroDivisionErrorwhen loading SVG images with zero or missingwidthattributeProblem
parse_size_to_px(imageelm.get('width', '0'))returns0when width is missing (default'0'), causings = width / imgwidthto crash with an unhelpfulZeroDivisionError.Test results
Fixes #109