Fix operator precedence in SegmentText rotation calculation#104
Closed
leofernandezg wants to merge 1 commit intocdelker:masterfrom
Closed
Fix operator precedence in SegmentText rotation calculation#104leofernandezg wants to merge 1 commit intocdelker:masterfrom
leofernandezg wants to merge 1 commit intocdelker:masterfrom
Conversation
The expression `rotation + transform.theta % 360` was evaluated as `rotation + (transform.theta % 360)` due to Python operator precedence, instead of the intended `(rotation + transform.theta) % 360`. This could produce rotation values exceeding 360 degrees (e.g. 395 instead of 35 when rotation=350 and theta=45). Added parentheses on both occurrences (xform and draw methods) and test/test_rotation.py to verify. Fixes cdelker#100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
segments.pyProblem
rotation + transform.theta % 360is evaluated asrotation + (transform.theta % 360)due to Python operator precedence, instead of(rotation + transform.theta) % 360. This produces rotation values exceeding 360 degrees.Test results
Fixes #100