security: add authorization checks to TransactionHttpHandler#16098
Open
mohammadmseet-hue wants to merge 1 commit intocdapio:developfrom
Open
security: add authorization checks to TransactionHttpHandler#16098mohammadmseet-hue wants to merge 1 commit intocdapio:developfrom
mohammadmseet-hue wants to merge 1 commit intocdapio:developfrom
Conversation
TransactionHttpHandler exposes transaction management endpoints on the external AppFabric port (11015) without any authorization enforcement. Sibling handlers on the same router (ConfigHandler, MonitorHandler) correctly use contextAccessEnforcer.enforce() for all operations. This adds ContextAccessEnforcer checks to all 12 endpoints: - GET endpoints: StandardPermission.GET - POST endpoints (invalidate, reset, truncate, prune): StandardPermission.UPDATE Matches the authorization pattern used by ConfigHandler and MonitorHandler on the same router binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransactionHttpHandlerexposes 12 transaction management endpoints on the external AppFabric router (port 11015) without any authorization enforcement. Sibling handlers on the same router (ConfigHandler,MonitorHandler) correctly callcontextAccessEnforcer.enforce()on every endpoint.This adds
ContextAccessEnforcerchecks to all 12 endpoints:StandardPermission.GETStandardPermission.UPDATEInconsistency addressed
enforce(InstanceId.SELF, GET)✓enforce(systemServiceId, UPDATE)✓Changes
ContextAccessEnforcerdependency via constructor injectionenforce()calls to all 12 handler methodsConfigHandlerandMonitorHandler