Fix versions array initialization in js.sh#161
Open
ericLemanissier wants to merge 1 commit intocatthehacker:masterfrom
Open
Fix versions array initialization in js.sh#161ericLemanissier wants to merge 1 commit intocatthehacker:masterfrom
ericLemanissier wants to merge 1 commit intocatthehacker:masterfrom
Conversation
Author
|
@panekj friendly ping, this ammends 9bf5e40#diff-fb1fd6921a65fc8e4ebf5c0b1f40096dfbf065fc48a9b2926b6c7208b4dcd841 |
Author
|
@ChristopherHX friendly ping, this would unlock the use of node24 for ghcr.io/catthehacker/ubuntu:js users |
ChristopherHX
approved these changes
Apr 13, 2026
Collaborator
ChristopherHX
left a comment
There was a problem hiding this comment.
Looks like a good syntax-wise change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixup 9bf5e40
Fixes js image creation: