fix: FindChildByHash not selecting RHS of inner tree#762
Merged
Conversation
mpolitzer
force-pushed
the
fix/builder-lhs-find-child
branch
3 times, most recently
from
d713a55 to
164d0c9
Compare
vfusco
previously approved these changes
Mar 17, 2026
There was a problem hiding this comment.
Pull request overview
Fixes Merkle tree lookup logic so FindChildByHash correctly traverses the RHS branch (and can match the current node), and adds regression tests to prevent the issue from recurring.
Changes:
- Update
Tree.FindChildByHashto return*Tree, match on the current node’sRootHash, and recurse intoinner.RHS(instead of incorrectly usinginner.LHStwice). - Add
TestFindChildByHashcovering simple, deeper (RHS) traversal, and not-found cases. - Introduce an additional digest constant used by the new tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/merkle/builder.go | Fixes FindChildByHash traversal/return behavior so lookups can succeed in RHS subtrees and at the current node. |
| internal/merkle/builder_test.go | Adds regression tests verifying correct lookup behavior across tree shapes and missing hashes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
mpolitzer
force-pushed
the
fix/builder-lhs-find-child
branch
from
164d0c9 to
e0438c3
Compare
mpolitzer
force-pushed
the
fix/builder-lhs-find-child
branch
from
e0438c3 to
37bf04f
Compare
vfusco
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.