Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a 2 MiB request body size limit to the inspect endpoint, matching the Cartesi Machine's CMIO RX buffer size, to avoid reading oversized payloads into memory.
Changes:
- Added
maxPayloadSizeconstant and body-size enforcement usingio.LimitReaderinServeHTTP - Added tests for payloads at and above the size limit
- Extracted
startServerhelper in tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/inspect/inspect.go | Limits request body reads to 2 MiB, returning 413 for oversized payloads |
| internal/inspect/inspect_test.go | Adds tests for max and over-limit payloads; extracts startServer helper |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
mpolitzer
reviewed
Mar 16, 2026
renatomaia
approved these changes
Mar 16, 2026
mpolitzer
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.