Skip to content

feat: upgrade sdk, devnet and rollups-node npm package.#450

Merged
brunomenezes merged 3 commits intoprerelease/v2-alphafrom
feat/cli-new-rollups-node-changes
Mar 16, 2026
Merged

feat: upgrade sdk, devnet and rollups-node npm package.#450
brunomenezes merged 3 commits intoprerelease/v2-alphafrom
feat/cli-new-rollups-node-changes

Conversation

@brunomenezes
Copy link
Contributor

@brunomenezes brunomenezes commented Mar 13, 2026

Summary

code change to support the upcoming node alpha.10. The changes are related to bumping devnet to v2.0.0-alpha.11, @rollups/contracts v2.2.0 and the SDK package.

The artefact used for this development: build artefact can be found here from branch next/2.0.

Dependencies

The dependency waits on the release of the node alpha.10. Once it is done, I can update the sdk and release it, then update this PR accordingly, and once it is merged, a new CLI release can be done.

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2026

🦋 Changeset detected

Latest commit: 0126151

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brunomenezes brunomenezes moved this from Todo to In progress in Rollups SDK Mar 13, 2026
@brunomenezes brunomenezes self-assigned this Mar 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 95.51% (🎯 0%) 1191 / 1247
🔵 Statements 95.51% 1191 / 1247
🔵 Functions 94.74% 90 / 95
🔵 Branches 0% 0 / 0
📁 File Coverage (12 files)
File Lines Statements Functions Branches Uncovered Lines
apps/cli/src/builder/directory.ts 🟢 100% 🟢 100% 🟢 100% 🔴 0% -
apps/cli/src/builder/docker.ts 🟢 88.68% 🟢 88.68% 🟡 75% 🔴 0% 83-85, 139-147
apps/cli/src/builder/empty.ts 🟢 100% 🟢 100% 🟢 100% 🔴 0% -
apps/cli/src/builder/none.ts 🟢 100% 🟢 100% 🟢 100% 🔴 0% -
apps/cli/src/builder/tar.ts 🟢 100% 🟢 100% 🟢 100% 🔴 0% -
apps/cli/src/compose/builder.ts 🟢 99.79% 🟢 99.79% 🟢 100% 🔴 0% 228
apps/cli/src/config.ts 🟢 92.63% 🟢 92.63% 🟢 94.12% 🔴 0% 65-66, 217, 226, 235, 255, ...
apps/cli/src/exec/cartesi-machine.ts 🟡 75% 🟡 75% 🟡 66.67% 🔴 0% 10-12, 28-30
apps/cli/src/exec/genext2fs.ts 🟢 96.92% 🟢 96.92% 🟢 100% 🔴 0% 87-88
apps/cli/src/exec/index.ts 🟢 100% 🟢 100% 🟢 100% 🔴 0% -
apps/cli/src/exec/mksquashfs.ts 🟢 91.23% 🟢 91.23% 🟢 100% 🔴 0% 68-72
apps/cli/src/exec/util.ts 🟢 94.44% 🟢 94.44% 🟢 100% 🔴 0% 47-48

@socket-security
Copy link

socket-security bot commented Mar 13, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​cartesi/​devnet@​2.0.0-alpha.10 ⏵ 2.0.0-alpha.1151 -4910036 -6496 -4100
Updated@​cartesi/​rollups@​2.1.1 ⏵ 2.2.0531009196 -3100
Addedtmp@​0.2.510010010082100
Addedsmol-toml@​1.6.010010010085100
Addedyaml@​2.8.29910010085100

View full report

@brunomenezes brunomenezes force-pushed the feat/cli-new-rollups-node-changes branch from 120b5a5 to 3cec98d Compare March 13, 2026 07:37
@brunomenezes
Copy link
Contributor Author

brunomenezes commented Mar 13, 2026

This commit here 827b23e will be removed once the PR #449 is merged, as I pushed that change there too. So, if you use cartesi run, the change avoids issues.

@brunomenezes
Copy link
Contributor Author

brunomenezes commented Mar 13, 2026

I recorded a little demo. (UPDATE: Ignore as the apps command was removed)

demo-apps-set-command.mov

@tuler
Copy link
Member

tuler commented Mar 13, 2026

Why do we need this new command?

@brunomenezes
Copy link
Contributor Author

brunomenezes commented Mar 13, 2026

Why do we need this new command?

As I understand it, a user can, at ease, re-enable an application that went into a failed state. Let me know if you don't think the change for the upcoming rollups-node does not worth the maintenance, and I will undo it.

@tuler
Copy link
Member

tuler commented Mar 13, 2026

As I understand it, a user can, at ease, re-enable an application that went into a failed state. Let me know if you don't think the change for the upcoming rollups-node does not worth the maintenance, and I will undo it.

From an node operator perspective it makes sense, but from an application developer perspective, why does he needs that command?

@brunomenezes
Copy link
Contributor Author

brunomenezes commented Mar 13, 2026

As I understand it, a user can, at ease, re-enable an application that went into a failed state. Let me know if you don't think the change for the upcoming rollups-node does not worth the maintenance, and I will undo it.

From an node operator perspective it makes sense, but from an application developer perspective, why does he needs that command?

What are the profile or profiles the cartesi-cli was meant to support? Is the initial assumption that it is only for application developers? Also, who develop the application never operates it?

@tuler
Copy link
Member

tuler commented Mar 13, 2026

What are the profile or profiles the cartesi-cli was meant to support?

Application developers developing locally.
For application operation on testnet or mainnet the rollups-node is used directly.

@brunomenezes
Copy link
Contributor Author

So, by what @tuler is saying, I figure we don't need that in the cartesi-cli for the users we discussed earlier @vfusco , do you agree with that? They would do it directly using the rollups-node. Also, it is my understanding that the release is just to package the next node, since the current set of features is perfectly fine without any extras, right @tuler? Just making sure my understanding of this thread is sound.

@@ -1,4 +1,4 @@
#!/usr/bin/env sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will only go into a new SDK release if there is a changeset for it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned here that the commit will be removed as I already pushed one in #449 , here is just in case one of you wanted to have a run and test locally to avoid figuring out why rollups-node was not starting.

@brunomenezes brunomenezes force-pushed the feat/cli-new-rollups-node-changes branch from 3cec98d to 827b23e Compare March 16, 2026 10:14
@brunomenezes brunomenezes changed the title feat: add new command and bump internal deps feat: upgrade sdk, devnet and rollups-node npm package. Mar 16, 2026
@brunomenezes brunomenezes force-pushed the feat/cli-new-rollups-node-changes branch from 834f21e to 2b4cad5 Compare March 16, 2026 15:31
@brunomenezes brunomenezes force-pushed the feat/cli-new-rollups-node-changes branch from 2b4cad5 to f308d80 Compare March 16, 2026 15:32
@brunomenezes brunomenezes marked this pull request as ready for review March 16, 2026 15:37
@brunomenezes brunomenezes requested a review from tuler March 16, 2026 15:37
@github-project-automation github-project-automation bot moved this from In progress to Waiting Merge in Rollups SDK Mar 16, 2026
@brunomenezes brunomenezes merged commit d0cbdbe into prerelease/v2-alpha Mar 16, 2026
4 checks passed
@brunomenezes brunomenezes deleted the feat/cli-new-rollups-node-changes branch March 16, 2026 16:07
@github-project-automation github-project-automation bot moved this from Waiting Merge to Done in Rollups SDK Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants