Fix NullPointerException in JavaBreakpoint.deregisterRequest when marker is null

[Copilot]

getMarker() can return null when a breakpoint is deregistered after its marker has been deleted. The existing code called .exists() without a null check, causing NPE.

Changes

• Added null check before marker.exists() call
• Stored marker in local variable to eliminate redundant getMarker() invocations

Before:

if (!(request instanceof ClassPrepareRequest) && getMarker().exists()) {
    decrementInstallCount();
}

After:

IMarker marker = getMarker();
if (!(request instanceof ClassPrepareRequest) && marker != null && marker.exists()) {
    decrementInstallCount();
}

Related to Bug 576200 (Stale Breakpoint Confusion) and Bug 354784 (DebugException: Breakpoint does not have an associated marker).

Original prompt

Problem

In org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/breakpoints/JavaBreakpoint.java, line 289, there is a potential NullPointerException when getMarker() returns null:

if (!(request instanceof ClassPrepareRequest) && getMarker().exists()) {
    decrementInstallCount();
}

This can happen when a breakpoint is being deregistered because the marker has already been deleted. The comment above even acknowledges this scenario:

// A request may be getting de-registered because the breakpoint has
// been deleted. It may be that this occurred because of a marker
// deletion.
// Don't try updating the marker (decrementing the install count) if
// it no longer exists.

However, the code doesn't properly guard against getMarker() returning null - it only checks if the marker exists, but calling .exists() on a null reference throws a NullPointerException.

This is related to GitHub Issue eclipse-jdt#55 (Stale Breakpoints and marker mismatch) and the underlying Eclipse bugs:

• Bug 576200 - Stale Breakpoint Confusion
• Bug 354784 - DebugException: Breakpoint does not have an associated marker

Solution

Add a null check before calling .exists():

Before:

if (!(request instanceof ClassPrepareRequest) && getMarker().exists()) {

After:

if (!(request instanceof ClassPrepareRequest) && getMarker() != null && getMarker().exists()) {

File to modify

org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/breakpoints/JavaBreakpoint.java

Line 289 in the deregisterRequest method.

This pull request was created from Copilot chat.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[carstenartur]

@copilot how can I rebase on followupstream branch?

[Copilot]

@copilot how can I rebase on followupstream branch?

I cannot perform git rebase operations directly. However, you can rebase this branch onto an upstream branch yourself with these steps:

1. First, add the upstream remote if not already added:

   git remote add upstream https://github.com/eclipse-jdt/eclipse.jdt.debug.git

2. Fetch the upstream branches:

   git fetch upstream

3. Rebase your branch onto the upstream branch:

   git rebase upstream/master

   (Replace master with the specific upstream branch name you want to rebase onto)

4. If there are conflicts, resolve them and continue:

   git add .
   git rebase --continue

5. Force push to update your PR:

   git push --force-with-lease origin copilot/fix-nullpointer-exception-bug

Note: If "followupstream" is a specific branch name, use that instead of "master" in step 3.

[carstenartur]

/rebase-upstream

[github-actions]

❌ Rebase failed due to conflicts.

To rebase manually:

git remote add upstream https://github.com/eclipse-jdt/eclipse.jdt.debug.git
git fetch upstream master
git rebase upstream/master
# Resolve conflicts
git rebase --continue
git push --force-with-lease

[carstenartur]

/rebase-upstream

[github-actions]

✅ Successfully rebased onto eclipse-jdt/eclipse.jdt.debug:master

[carstenartur]

/rebase-upstream

[github-actions]

❌ Rebase succeeded but push failed due to insufficient permissions.

Possible causes:

• The PR author has not enabled "Allow edits by maintainers"
• The fork repository has restricted push access

To enable automatic rebase:

1. Go to the PR page
2. Check "Allow edits by maintainers" in the sidebar
3. Try the /rebase-upstream command again

Or rebase manually:

git remote add upstream https://github.com/eclipse-jdt/eclipse.jdt.debug.git
git fetch upstream master

# Determine the number of commits in your PR
# You can find this on the PR page under "Commits" tab
# Example: if your PR has 3 commits, set PR_COMMIT_COUNT=3
PR_COMMIT_COUNT=3

# Rebase only your PR commits onto upstream/master
git rebase --onto upstream/master HEAD~${PR_COMMIT_COUNT}

git push --force-with-lease