Various minor fixes#35
Conversation
“method: A function which is defined inside a class body.” This is not the case for most of these functions. https://docs.python.org/3/glossary.html#term-method
These are cases which actually refer to methods, split into their own commit
`Grass::eaten` is a C++-ism; Python uses `Grass.eaten`
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/pando-python/compare/md-outputs..md-outputs-PR-35 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-02-23 19:32:35 +0000 |
Robadob
left a comment
There was a problem hiding this comment.
All looks good.
I think my preference for method (albeit I'm by no means consistent) stems from a teacher we had at a-levels, whining about function not being precisely correct in some circumstances. I don't recall their exact argument, but it's stuck with me.
Auto-generated via `{sandpaper}`
Source : 566b807
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-02-24 13:13:16 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 98d9d41
Branch : main
Author : Jost Migenda <jost.migenda@kcl.ac.uk>
Time : 2026-02-24 13:11:16 +0000
Message : Merge pull request #35 from JostMigenda/various_fixes
Various minor fixes
Grass.eateninstead ofGrass::eaten