Remove @mark.fails_on_windows to enable Windows test support#42
Open
Spitfire1900 wants to merge 1 commit intocarletes:masterfrom
Open
Remove @mark.fails_on_windows to enable Windows test support#42Spitfire1900 wants to merge 1 commit intocarletes:masterfrom
Spitfire1900 wants to merge 1 commit intocarletes:masterfrom
Conversation
Add platform detection for Windows/Unix command differences and skip chmod/chown permission checks on Windows where these aren't supported.
ddd4aba to
17b6892
Compare
Owner
|
Thanks, @Spitfire1900! Did you have a chance of testing this on a Windows system? I do not have any around, so I cannot do that. Do you know whether they can be selected on Github Actions, by the way? |
Collaborator
Author
|
Despite passing in GH actions attempting to reproduce the pass locally resulted in issues. This is not ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add platform detection for Windows/Unix command differences and skip chmod/chown permission checks on Windows where these aren't supported.