feat(apps:devices): support multiple --device-id flags for forcechannel and unforcechannel#132
Open
feat(apps:devices): support multiple --device-id flags for forcechannel and unforcechannel#132
--device-id flags for forcechannel and unforcechannel#132Conversation
…annel` and `unforcechannel`
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the apps/devices CLI commands to support bulk forcing/unforcing a channel across multiple devices, using a new bulk update DTO and service method that targets PATCH /v1/apps/{appId}/devices?ids=....
Changes:
- Added
UpdateAppDevicesDtoto represent bulk device updates. - Introduced
appDevicesService.updateMany()to PATCH multiple devices at once via anidsquery param. - Updated
forcechannelandunforcechannelto accept repeated--device-idvalues and adjusted success messaging to reflect device count.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/types/app-device.ts | Adds a DTO type for bulk device updates. |
| src/services/app-devices.ts | Adds updateMany() service method to PATCH multiple devices by ids query param. |
| src/commands/apps/devices/forcechannel.ts | Accepts multiple --device-id values and uses updateMany() for bulk forcing. |
| src/commands/apps/devices/unforcechannel.ts | Accepts multiple --device-id values and uses updateMany() for bulk unforcing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateAppDevicesDtotype andupdateManyservice method for bulk device updates viaPATCH /v1/apps/{appId}/devices?ids=...--device-idoption from single string to array in bothforcechannelandunforcechannelcommands