feat(apps:builds): add --path option to upload local source files#131
Open
feat(apps:builds): add --path option to upload local source files#131
--path option to upload local source files#131Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for creating app builds from a local source directory by introducing a --path option that zips and uploads sources (multipart), then creates a build referencing the uploaded source.
Changes:
- Add
--pathtoapps:builds:create, validate inputs, and passappBuildSourceIdwhen building from uploaded sources. - Introduce
app-build-sourcesservice for multipart uploads (similar to bundle file uploads). - Add
zipFolderWithGitignoreutility to zip directories while respecting.gitignoreand excluding.git/.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/zip.ts | Adds a gitignore-aware directory zip helper used by --path. |
| src/types/index.ts | Re-exports new build source types. |
| src/types/app-build.ts | Extends build DTOs to support appBuildSourceId and optional gitRef. |
| src/types/app-build-source.ts | Defines DTOs for build source creation and status. |
| src/services/app-build-sources.ts | Implements multipart upload flow for build source archives. |
| src/commands/apps/builds/create.ts | Adds --path option, validation, zipping, uploading, and build creation wiring. |
| package.json | Adds globby dependency for gitignore-aware file discovery. |
| package-lock.json | Locks dependency graph updates for globby and transitive deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--pathoption toapps:builds:createfor uploading local source files instead of using a git referenceapp-build-sourcesservice with multipart upload support (same pattern as bundle files)zipFolderWithGitignoreutility that zips a directory while respecting.gitignoreand excluding.git/--pathand--git-refare mutually exclusive;--pathvalidates the directory exists and contains apackage.jsonTest plan
npm run buildcompiles without errorsnpx capawesome apps:builds:create --helpshows--pathoption--path .zips, uploads, and triggers a build using the uploaded source--path+--git-reftogether errors out--pathpointing to non-directory or missingpackage.jsonerrors out--path, existing git ref flow works unchanged