feat(apps:certificates): deprecate --type option#130
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deprecates the --type flag for the apps:certificates:create and apps:certificates:update CLI commands by warning when it’s used, while removing type from the create/update request DTOs and payloads because the backend now auto-detects certificate type.
Changes:
- Removed
typefromCreateAppCertificateDto/UpdateAppCertificateDto. - Stopped sending
typein the create multipart payload. - Added runtime warnings when
--typeis provided (and removed the interactive prompt that previously required selecting a type).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/types/app-certificate.ts | Drops type from create/update DTOs to match new API behavior. |
| src/services/app-certificates.ts | Removes type from multipart create payload. |
| src/commands/apps/certificates/create.ts | Removes interactive type selection and warns when deprecated --type is used. |
| src/commands/apps/certificates/update.ts | Warns when deprecated --type is used and omits it from update payload. |
Comments suppressed due to low confidence (1)
src/commands/apps/certificates/update.ts:55
- The new deprecation warning behavior in this command isn’t covered by tests. Consider adding a Vitest test asserting
consola.warnis emitted whentypeis provided and that the update call body does not includetype, similar to the coverage for other deprecated flags (e.g.apps:channels:create).
if (type) {
consola.warn('The --type option is deprecated. The certificate type is now detected automatically.');
}
await appCertificatesService.update({
appId,
certificateId,
name,
password,
keyAlias,
keyPassword,
});
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--typeoption inapps:certificates:createandapps:certificates:updatecommands--typeis used, as the certificate type is now detected automatically by the APItypefrom the backend payloads and DTOs