Skip to content

add notification POST response logging#118

Merged
StoilAtSAP merged 1 commit intocap-js:mainfrom
sleibach:main
Apr 1, 2026
Merged

add notification POST response logging#118
StoilAtSAP merged 1 commit intocap-js:mainfrom
sleibach:main

Conversation

@sleibach
Copy link
Copy Markdown
Contributor

The logged info is needed when support tickets need to be opened regarding business notifications.

Copy link
Copy Markdown
Collaborator

@StoilAtSAP StoilAtSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR and looks good to merge.

Testing done:

  • All 55 plugin tests pass ✅
  • Integration with incidents-app works with no regressions ✅
  • Code changes are minimal and well-structured

What it adds:

  • Captures the full HTTP response from ANS API (was previously discarded)
  • Logs response body + headers at debug level for troubleshooting
  • Returns the response object so applications can use it if needed
  • Adds Accept: application/json header

Risk: Very low - backward compatible, only affects debug logging and return value when outbox is disabled.

This solves a real support problem when debugging notification issues. 👍

@StoilAtSAP StoilAtSAP merged commit dbcb26b into cap-js:main Apr 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants