add notification POST response logging#118
Merged
StoilAtSAP merged 1 commit intocap-js:mainfrom Apr 1, 2026
Merged
Conversation
StoilAtSAP
approved these changes
Apr 1, 2026
Collaborator
StoilAtSAP
left a comment
There was a problem hiding this comment.
Tested this PR and looks good to merge.
Testing done:
- All 55 plugin tests pass ✅
- Integration with incidents-app works with no regressions ✅
- Code changes are minimal and well-structured
What it adds:
- Captures the full HTTP response from ANS API (was previously discarded)
- Logs response body + headers at debug level for troubleshooting
- Returns the response object so applications can use it if needed
- Adds Accept: application/json header
Risk: Very low - backward compatible, only affects debug logging and return value when outbox is disabled.
This solves a real support problem when debugging notification issues. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logged info is needed when support tickets need to be opened regarding business notifications.