Skip to content

ci: split perf workflow#272

Open
upils wants to merge 7 commits intocanonical:mainfrom
upils:fix/split-performance-worflow
Open

ci: split perf workflow#272
upils wants to merge 7 commits intocanonical:mainfrom
upils:fix/split-performance-worflow

Conversation

@upils
Copy link
Collaborator

@upils upils commented Mar 6, 2026

  • Have you signed the CLA?

Do not expose the token used to write the comment to PRs from forks.
In the workflow posting the comment, use a fine-grained token with the
minimum permissions.

Do not expose the token used to write the comment to PRs from forks.
@upils upils requested review from cjdcordeiro and letFunny March 6, 2026 08:59
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, thank for looking into this Paul. It would be nice if we can get some guidance for security as well.

@upils upils requested a review from cjdcordeiro March 9, 2026 10:31
@upils upils requested a review from lczyk March 10, 2026 09:47
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Paul for taking care of this, it looks great. Let's see how it works once it is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants