On canvas linting overlays#71
Draft
nikku wants to merge 2 commits into
Draft
Conversation
nikku
force-pushed
the
on-canvas-linting-overlays
branch
from
8a884da to
1b11719
Compare
Member
Author
|
Marked it as draft as someone would need to take this over / add test cases. |
Member
Author
|
Missing to complete this:
|
philippfromme
force-pushed
the
rework-annotations
branch
2 times, most recently
from
2c50508 to
0925f71
Compare
philippfromme
force-pushed
the
on-canvas-linting-overlays
branch
from
1b11719 to
74e34ab
Compare
|
That looks good - I have one comment regarding the tooltip background - for UI consistency and better visibility, we use a dark background. |
nikku
force-pushed
the
on-canvas-linting-overlays
branch
from
74e34ab to
e6e40ee
Compare
Member
Author
|
@YanaSegal I've updated the example to feature multiple lint errors, cf. screen capture below:
If we want to pursue the dark route then we'd need to have appropriate styling for these errors, decide not to move to the dark side, or decide to not add the overlays at last. |
Member
Author
|
@YanaSegal and myself made the decision to park this initiative. The play team may come up with a solution that we can work with. |
nikku
added
backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds on canvas linting annotations to provide more immediate access to issues.
Can be tried out via
Closes #68