Support cancel execution listener rules and start event forms rules#156
Conversation
Related to camunda/camunda-modeler#5929 deps: update to `bpmnlint-plugin-camunda-compat@2.51.0`
There was a problem hiding this comment.
Pull request overview
Adds Camunda compatibility linting support for zeebe:ExecutionListener with cancel event type, including updated dependency versions and error message handling to accommodate future event types without further code changes.
Changes:
- Update
bpmnlint-plugin-camunda-compatto^2.51.0(and bumpbpmn-js-properties-paneldev dependency). - Add/enable cancel execution listener rules in the bundled compiled config.
- Extend error message adjustment + add tests for
cancelexecution listener support gating (Camunda >= 8.10).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/spec/utils/properties-panel.spec.js | Adds properties panel test asserting cancel event type is flagged as unsupported on Camunda < 8.10. |
| test/spec/utils/error-messages.spec.js | Adds error message test for cancel execution listener support gating. |
| package.json | Bumps bpmnlint-plugin-camunda-compat and bpmn-js-properties-panel versions. |
| package-lock.json | Locks updated dependency versions and integrity hashes. |
| lib/utils/properties-panel.js | Adjusts per-entry properties panel error messaging for execution listener eventType. |
| lib/utils/error-messages.js | Generalizes execution listener eventType support error message formatting (introduces camelCase → sentence conversion). |
| lib/compiled-config.js | Enables/bundles new cancel execution listener rules for browser usage. |
| CHANGELOG.md | Documents the new feature and dependency bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I also committed a version bump for
The deprecation message itself is generic and doesn't need any adjustments, so it's just a routine version bump. |
OK but I will need to update the properties panel too in that case as one cannot even try out the new rule on the test setup. |
|
@AlekseyManetov We'd need an adjustment for start event forms though: |
|
@barmac Start event form error message in properties panel is adjusted
|
|
I'd rather keep it short: Only supported in Camunda 8.3 or newer. We already have this pattern in this library. |
| } | ||
|
|
||
| if (id === 'formType' && type === ERROR_TYPES.EXTENSION_ELEMENT_NOT_ALLOWED) { | ||
| return `Embedded form on Start Event is only supported by Camunda ${ allowedVersion } or newer.`; |
There was a problem hiding this comment.
@claude[agent] shorten this to use not supported message helper. Adjust the test.
There was a problem hiding this comment.
There was a problem hiding this comment.
Done in 6374ab5. Changed to use getNotSupportedMessage('', allowedVersion) helper function, which produces "Only supported by Camunda 8.3 or newer." message. Test updated accordingly.
8c089f2 to
6374ab5
Compare
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
5c7fdaa to
2d08ca5
Compare
|
Works for me! I squashed the commits and re-wrote the messages as feat. |
2d08ca5 to
22996c2
Compare




Related to camunda/camunda-modeler#5929
deps: update to
bpmnlint-plugin-camunda-compat@2.51.0Proposed Changes
This PR adds support for the cancel execution listener rules. Also, we get ready for the future event types rules without code adjustments.
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}