test: remove 151 unit tests fully covered by integration tests#595
test: remove 151 unit tests fully covered by integration tests#595thymikee wants to merge 1 commit into
Conversation
Per-test coverage analysis confirmed every statement and branch these tests exercise is already covered by the provider-integration suite. Removes 8 fully redundant test files and 132 individual tests from 54 files (2,598 lines). Coverage unchanged at 82.4% statements / 84.5% lines, both above configured thresholds.
|
There was a problem hiding this comment.
💡 Codex Review
agent-device/src/__tests__/upload-client.test.ts
Lines 283 to 284 in f31f7aa
This removal drops the only test that verifies uploadArtifact falls back to legacy /upload when either the signed PUT upload or /upload/finalize fails (503). The remaining tests still cover preflight fallback and happy-path direct upload, but not this degraded-path behavior, so a regression here would surface as production upload failures during transient storage/finalize outages.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert.equal(pkg.exports['./android-apps'], undefined); | ||
| assert.equal(pkg.exports['./daemon'], undefined); |
There was a problem hiding this comment.
Restore package export-map contract test
Deleting this file removes the only check that package.json exports exactly the supported public subpaths and keeps internal ones (./android-apps, ./daemon) unexported. Provider integration coverage can execute the same runtime code without validating the published export map, so a future exports regression would pass CI here but break consumers at import time after release.
Useful? React with 👍 / 👎.
Summary
Coverage before/after
Files deleted entirely (8)
src/__tests__/artifacts-public.test.tssrc/__tests__/client-public.test.tssrc/__tests__/package-exports.test.tssrc/commands/react-native/__tests__/overlay.test.tssrc/core/__tests__/dispatch-screenshot.test.tssrc/daemon/handlers/__tests__/snapshot-routing.test.tssrc/utils/__tests__/device-isolation.test.tssrc/utils/__tests__/video.test.tsMethodology
vitest run --project provider-integration --coverage)vitest run --testNamePattern "^exact name$" --coverage)vitest run --coverageto confirm all remaining tests pass and thresholds holdTest plan