feat(activity): add default activity options to make it easier to use#76
feat(activity): add default activity options to make it easier to use#76shijiesheng wants to merge 2 commits intocadence-workflow:mainfrom
Conversation
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
2ec1c89 to
6e8a32d
Compare
Code Review ✅ Approved 1 resolved / 1 findingsAdds default activity options to simplify the API usage with sensible built-in configuration values. No issues found. ✅ 1 resolved✅ Bug: Validation block is now dead code due to defaults
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
| from cadence.workflow import WorkflowContext, WorkflowInfo, ResultType, ActivityOptions | ||
|
|
||
| default_activity_options = ActivityOptions( | ||
| schedule_to_close_timeout=timedelta(minutes=10), |
There was a problem hiding this comment.
what's the rationale behind the 10 min start to close timeout?
There was a problem hiding this comment.
10m is chosen arbitrarily. Maybe 1hr? Anything more than that should need a heartbeat setting.
What changed?
Set default activity options when execute_activity
Why?
Otherwise, each activity needs to set the options and it's a toil for onboarding.
How did you test it?
Unit Test
Potential risks
Release notes
Documentation Changes