Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following changes were made to try and fix this issue with our nix updating workflow
Trigger: pull_request_target instead of pull_request + push
GITHUB_TOKENhas write access to the PR branch even for fork PRsCargo.lock,package.nix, or the workflow itself changes; no more wasted runsCommit via GitHub API instead of git push
gh api repos/.../contents/package.nix --method PUTto commit the updated file directly through the APIgit commit --amend, nogit rebase, nogit push --forceFork PR handling
Deprecated action replaced
Additionally, we now conditionally run our CI based on what folders/files were edited.
I had Opus 4.6 via Cursor complete this entire change for me.