Skip to content

[perf][cp] Start prefetch from the first split in table scan#369

Open
guhaiyan0221 wants to merge 3 commits intobytedance:mainfrom
guhaiyan0221:fix_cp_scan_prefetch
Open

[perf][cp] Start prefetch from the first split in table scan#369
guhaiyan0221 wants to merge 3 commits intobytedance:mainfrom
guhaiyan0221:fix_cp_scan_prefetch

Conversation

@guhaiyan0221
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #191

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Summary:
getSplit() reads a split, while checkPreload() preloads one. Previously, prefetching began with the second split. By calling checkPreload() before getSplit(), prefetching can now start from the first split.

Corresponding PR: facebookincubator/velox#15460

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
  • Positive Impact: I have run benchmarks.
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note:

Release Note:
- Fixed a crash in `substr` when input is null.
- optimized `group by` performance by 20%.

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

Summary:
`getSplit()` reads a split, while `checkPreload()` preloads one. Previously,
prefetching began with the second split. By calling `checkPreload()` before
`getSplit()`, prefetching can now start from the first split.

Corresponding PR: facebookincubator/velox#15460
@guhaiyan0221 guhaiyan0221 requested a review from fzhedu March 10, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants