[fix][cp] UT only for 'fix: Unloaded lazy vector in duplicate field project#365
Merged
guhaiyan0221 merged 1 commit intobytedance:mainfrom Apr 7, 2026
Merged
Conversation
…roject' Summary: The following error was noticed when running a query as below, where the filter expressions were for one field and duplicate projects were for another field. > SELECT id, id FROM tmp WHERE name = 'John' The lazy vector is not preloaded because it’s only referenced in identity projections, not in expressions, and the `fillOutput` calls `wrapInDictionary` multiple times on the same lazy vector. The lazy vector is still unloaded at the time, and thus, the dictionary vector wraps the same underlying lazy vector multiple times while unloaded. This PR fixes this issue by caching the already wrapped children to avoid wrapping the same child multiple times.
449dc5f to
96cc6d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: discussion #191
Type of Change
Description
Bolt has already fixed the overflow error; still cherry-pick the UT to ensure the mentioned case is covered
Summary:
The following error was noticed when running a query as below, where the filter expressions were for one field and duplicate projects were for another field.
The lazy vector is not preloaded because it’s only referenced in identity projections, not in expressions, and the
fillOutputcallswrapInDictionarymultiple times on the same lazy vector. The lazy vector is still unloaded at the time, and thus, the dictionary vector wraps the same underlying lazy vector multiple times while unloaded.This PR fixes this issue by caching the already wrapped children to avoid wrapping the same child multiple times.
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes