Skip to content

Fix RuboCop violations with configuration #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonnyt merged 2 commits into from
Jan 23, 2026
Merged

Fix RuboCop violations with configuration #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b96ce
Initial plan
Copilot Jan 23, 2026
60d2a60
Fix RuboCop violations by adding .rubocop.yml configuration
Copilot Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# RuboCop configuration

AllCops:
NewCops: enable
TargetRubyVersion: 2.7

# Disable BlockLength for RSpec files as it's standard practice
# RSpec describe blocks can be long and that's expected
Metrics/BlockLength:
Exclude:
- 'spec/**/*_spec.rb'

# Increase thresholds slightly for AbcSize to accommodate existing code
Metrics/AbcSize:
Max: 25

# Increase threshold slightly for MethodLength to accommodate existing code
Metrics/MethodLength:
Max: 15

# Allow development dependencies in gemspec (common practice)
Gemspec/DevelopmentDependencies:
Enabled: false
3 changes: 2 additions & 1 deletion bundleup.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ Gem::Specification.new do |spec|
spec.metadata = {
'homepage_uri' => spec.homepage,
'source_code_uri' => 'https://github.com/bundleup/bundleup-sdk-ruby',
'changelog_uri' => 'https://github.com/bundleup/bundleup-sdk-ruby/blob/main/CHANGELOG.md'
'changelog_uri' => 'https://github.com/bundleup/bundleup-sdk-ruby/blob/main/CHANGELOG.md',
'rubygems_mfa_required' => 'true'
}

spec.files = Dir['lib/**/*', 'LICENSE', 'README.md', 'CHANGELOG.md']
Expand Down