Skip to content

Found new managed modules references#1164

Merged
pkwarren merged 1 commit intomainfrom
fetch-modules
Feb 26, 2026
Merged

Found new managed modules references#1164
pkwarren merged 1 commit intomainfrom
fetch-modules

Conversation

@app-token-modules
Copy link
Contributor

No description provided.

@app-token-modules app-token-modules bot requested a review from a team February 26, 2026 12:15
},
{
"name": "v34.0",
"digest": "946278992baee216f7742401780df3727195ffc068a30e21769c7e808d16ee25e9e48e51f938b6ddbe405abe46c45091a56ad90aac1cad0d809d16cbad889ff1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files changed: 0 removed, 0 renamed, 0 added, 4 changed content

Files changed content:

--- shake256:2d4c664294ebf2759e1c7460e0f4b69d3835d7ff8fce4b8fde4a5fd87d55e794764834715eb91525ccbda422f7d3f24fca89428da044eb37e2be43c60c8e10a4  google/protobuf/descriptor.proto
+++ shake256:1b87b903df1d64270e3b8c3458bdd28ad8a9e29feeca3da0e51ede2421d90d7c90c1b3a0b314c7e272eb3bf8b208f2f9addf1a2d9c7a1fc582162d832677a3a3  google/protobuf/descriptor.proto
@@ -476,8 +476,18 @@
   // named by java_outer_classname.  However, the wrapper class will still be
   // generated to contain the file's getDescriptor() method as well as any
   // top-level extensions defined in the file.
-  optional bool java_multiple_files = 10 [default = false];
+  optional bool java_multiple_files = 10 [
+    default = false,
+    feature_support = {
+      edition_introduced: EDITION_PROTO2
+      edition_removed: EDITION_2024
+      removal_error: "This behavior is enabled by default in editions 2024 and above. "
+                     "To disable it, you can set `features.(pb.java).nest_in_file_class = YES` "
+                     "on individual messages, enums, or services."
 
+    }
+  ];
+
   // This option does nothing.
   optional bool java_generate_equals_and_hash = 20 [deprecated=true];
 
@@ -825,6 +835,10 @@
     // this one, the last default assigned will be used, and proto files will
     // not be able to override it.
     optional Edition edition_removed = 4;
+
+    // The removal error text if this feature is used after the edition it was
+    // removed in.
+    optional string removal_error = 5;
   }
   optional FeatureSupport feature_support = 22;
 

--- shake256:d1706fd968269712822f6b51b3ffab303ccdd33c58b4d6c8414083a4fadb448bfd858d77088649165adfe9a08847f007611a3584718e63884e61f75c8bca7a5c  google/protobuf/field_mask.proto
+++ shake256:bb302c93a15ea3b9ad881841c5148e5f7ac12089bcf7ab7d3e1fa51748e7b082986646497f01b2748fa676884958dc69bbf902f4b066c190c5e92c2338ea3f6e  google/protobuf/field_mask.proto
@@ -152,24 +152,22 @@
 // An implementation may provide options to override this default behavior for
 // repeated and message fields.
 //
-// In order to reset a field's value to the default, the field must
-// be in the mask and set to the default value in the provided resource.
-// Hence, in order to reset all fields of a resource, provide a default
-// instance of the resource and set all fields in the mask, or do
-// not provide a mask as described below.
+// Note that libraries which implement FieldMask resolution have various
+// different behaviors in the face of empty masks or the special "*" mask.
+// When implementing a service you should confirm these cases have the
+// appropriate behavior in the underlying FieldMask library that you desire,
+// and you may need to special case those cases in your application code if
+// the underlying field mask library behavior differs from your intended
+// service semantics.
 //
-// If a field mask is not present on update, the operation applies to
-// all fields (as if a field mask of all fields has been specified).
-// Note that in the presence of schema evolution, this may mean that
-// fields the client does not know and has therefore not filled into
-// the request will be reset to their default. If this is unwanted
-// behavior, a specific service may require a client to always specify
-// a field mask, producing an error if not.
+// Update methods implementing https://google.aip.dev/134
+// - MUST support the special value * meaning "full replace"
+// - MUST treat an omitted field mask as "replace fields which are present".
 //
-// As with get operations, the location of the resource which
-// describes the updated values in the request message depends on the
-// operation kind. In any case, the effect of the field mask is
-// required to be honored by the API.
+// Other methods implementing https://google.aip.dev/157
+// - SHOULD support the special value "*" to mean "get all".
+// - MUST treat an omitted field mask to mean "get all", unless otherwise
+// documented.
 //
 // ## Considerations for HTTP REST
 //

--- shake256:da1dc4060f405ccda4033e045769b64c29d39b2fa0acd8a17800f371e9df6761a5f4fb09ae3a17b2457724c29177cf8b92849f3faba00522bd693c734ddd4340  google/protobuf/go_features.proto
+++ shake256:987ab316a58390b7617eb2cf6446798925df326e54052eb5a3a128174816213998c73c84ea7efc88d143ed1163768e18410da4bd08b330829fe536974ff95ebe  google/protobuf/go_features.proto
@@ -80,4 +80,33 @@
       value: "STRIP_ENUM_PREFIX_KEEP"
     }
   ];
+
+  // Wrap the OptimizeMode enum in a message for scoping:
+  // This way, users can type shorter names (SPEED, CODE_SIZE).
+  message OptimizeModeFeature {
+    // The name of this enum matches OptimizeMode in descriptor.proto.
+    enum OptimizeMode {
+      // OPTIMIZE_MODE_UNSPECIFIED results in falling back to the default
+      // (optimize for code size), but needs to be a separate value to distinguish
+      // between an explicitly set optimize mode or a missing optimize mode.
+      OPTIMIZE_MODE_UNSPECIFIED = 0;
+      SPEED = 1;
+      CODE_SIZE = 2;
+      // There is no enum entry for LITE_RUNTIME (descriptor.proto),
+      // because Go Protobuf does not have the concept of a lite runtime.
+    }
+  }
+
+  optional OptimizeModeFeature.OptimizeMode optimize_mode = 4 [
+    retention = RETENTION_RUNTIME,
+    targets = TARGET_TYPE_MESSAGE,
+    targets = TARGET_TYPE_FILE,
+    feature_support = {
+      edition_introduced: EDITION_2024,
+    },
+    edition_defaults = {
+      edition: EDITION_LEGACY,
+      value: "OPTIMIZE_MODE_UNSPECIFIED"
+    }
+  ];
 }

--- shake256:93a810721dfe089dd61b6a954cbab842c3c6cb9c814cb6286589f66fd148151151847291fd5668bcb8002f6f298364721e1c7c474e1be5d0d184ff37a635d8ce  google/protobuf/timestamp.proto
+++ shake256:a5be7415503570c9c1d12eef6a90462e25fdad242d262bf35bd167589fd0d31306b76e850dd41044a46e0722beeafafce3bcee0386c3b730be26c18ba84acc8d  google/protobuf/timestamp.proto
@@ -112,8 +112,8 @@
 // {hour}, {min}, and {sec} are zero-padded to two digits each. The fractional
 // seconds, which can go up to 9 digits (i.e. up to 1 nanosecond resolution),
 // are optional. The "Z" suffix indicates the timezone ("UTC"); the timezone
-// is required. A proto3 JSON serializer should always use UTC (as indicated by
-// "Z") when printing the Timestamp type and a proto3 JSON parser should be
+// is required. A ProtoJSON serializer should always use UTC (as indicated by
+// "Z") when printing the Timestamp type and a ProtoJSON parser should be
 // able to accept both UTC and other timezones (as indicated by an offset).
 //
 // For example, "2017-01-15T01:30:15.01Z" encodes 15.01 seconds past
@@ -132,7 +132,7 @@
 //
 message Timestamp {
   // Represents seconds of UTC time since Unix epoch 1970-01-01T00:00:00Z. Must
-  // be between -315576000000 and 315576000000 inclusive (which corresponds to
+  // be between -62135596800 and 253402300799 inclusive (which corresponds to
   // 0001-01-01T00:00:00Z to 9999-12-31T23:59:59Z).
   int64 seconds = 1;

@pkwarren pkwarren merged commit 6aa4419 into main Feb 26, 2026
5 checks passed
@pkwarren pkwarren deleted the fetch-modules branch February 26, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant