fix: broadcast context and status code improvements#45
Merged
Conversation
- Detach broadcast goroutines from request context using WithoutCancel so client disconnect doesn't cancel in-flight broadcasts - Use shared broadcast context with 15s timeout per fan-out operation, cancelled only when all goroutines complete - Set StatusCode on TransactionStatus at construction in submitToTeranodeSync: pass through teranode HTTP codes, 503 for network failures, 504 for timeouts - Simplify collection loop to range over buffered channel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context.WithoutCancelso client disconnect doesn't cancel in-flight teranode submissionsStatusCodeonTransactionStatusat construction insubmitToTeranodeSync: pass through teranode HTTP codes, 503 for network failures, 504 for timeoutsselect-based torangeover buffered channelTest plan
StatusCodeis non-zero in SSE events and webhook callbacks