chore(deps): upgrade runtime and test dependencies#102
Open
amio wants to merge 1 commit intobruce:masterfrom
Open
chore(deps): upgrade runtime and test dependencies#102amio wants to merge 1 commit intobruce:masterfrom
amio wants to merge 1 commit intobruce:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
rimrafto the latest major and switch internal cleanup code from callback-style invocation to the package's modern promise/sync exports.mkdirpto the latest major and adapt directory creation to its named exports and promise/sync API.mochato the latest major and keep the current test surface running under the new runner version.If we consider modernizing this package, we may also remove
rimraf,mkdirpfrom dependencies. Nodejs already have builtin functions handles these case nicely. And evenmocha, the nodejs builtin test runner is marked stable since v20.