Skip to content

feat(collator): add test one shard block per master#1040

Merged
serejkaaa512 merged 1 commit intomasterfrom
feature/test-shard-collation
Mar 11, 2026
Merged

feat(collator): add test one shard block per master#1040
serejkaaa512 merged 1 commit intomasterfrom
feature/test-shard-collation

Conversation

@serejkaaa512
Copy link
Copy Markdown
Contributor

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None]

COMPATIBILITY

[Yes]

SPECIAL DEPLOYMENT ACTIONS

[Not Required]

PERFORMANCE IMPACT

[No impact expected]

TESTS

Unit Tests

Add new test_one_shard_block_per_master_block .

Network Tests

[No coverage]

Manual Tests

Add dump with one external, check collated blocks ordering.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 26, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1040

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1040
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1040 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@serejkaaa512 serejkaaa512 marked this pull request as draft February 26, 2026 09:29
@serejkaaa512 serejkaaa512 linked an issue Feb 26, 2026 that may be closed by this pull request
@serejkaaa512 serejkaaa512 force-pushed the feature/test-shard-collation branch from 57fee12 to 7502d03 Compare February 26, 2026 10:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.15%. Comparing base (72f2322) to head (c991610).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cli/src/cmd/tools/dump_state.rs 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
+ Coverage   54.77%   55.15%   +0.37%     
==========================================
  Files         415      415              
  Lines       69641    69652      +11     
  Branches    69641    69652      +11     
==========================================
+ Hits        38148    38417     +269     
+ Misses      29552    29288     -264     
- Partials     1941     1947       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@serejkaaa512 serejkaaa512 self-assigned this Feb 27, 2026
@serejkaaa512 serejkaaa512 marked this pull request as ready for review February 27, 2026 12:56
@serejkaaa512 serejkaaa512 requested a review from SmaGMan February 27, 2026 12:56
@serejkaaa512 serejkaaa512 force-pushed the feature/test-shard-collation branch 4 times, most recently from 43301b4 to b89e024 Compare March 4, 2026 08:56
Comment thread collator/tests/collation_tests.rs Outdated
Comment thread collator/tests/collation_tests.rs Outdated
@serejkaaa512 serejkaaa512 force-pushed the feature/test-shard-collation branch 8 times, most recently from ee77f68 to f3ec99d Compare March 9, 2026 13:07
@serejkaaa512 serejkaaa512 force-pushed the feature/test-shard-collation branch from f3ec99d to c991610 Compare March 9, 2026 15:28
Copy link
Copy Markdown
Member

@SmaGMan SmaGMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@serejkaaa512 serejkaaa512 requested a review from pashinov March 10, 2026 11:36
@serejkaaa512 serejkaaa512 added this pull request to the merge queue Mar 11, 2026
Merged via the queue into master with commit fbad76e Mar 11, 2026
22 of 23 checks passed
@serejkaaa512 serejkaaa512 deleted the feature/test-shard-collation branch March 11, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a test for producing one shard block per master block

3 participants