remove implicit cast from enum to uint64 index#6744
Merged
Conversation
The arithmetic operators implicitly cast an enum value to a uint64 corresponding to the value's index in the enum type. The "==" and "!=" comparison operators (but no others) also perform this implicit cast in sam (but not in vam). This isn't an important feature, so rather than make the comparison behavior more consistent, remove it.
mattnibs
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arithmetic operators implicitly cast an enum value to a uint64 corresponding to the value's index in the enum type. The "==" and "!=" comparison operators (but no others) also perform this implicit cast in sam (but not in vam). This isn't an important feature, so rather than make the comparison behavior more consistent, remove it.