Updated logger imports from the new PathVisio4 version compatibility#3
Open
traybug23 wants to merge 1 commit intobridgedb:mainfrom
Open
Updated logger imports from the new PathVisio4 version compatibility#3traybug23 wants to merge 1 commit intobridgedb:mainfrom
traybug23 wants to merge 1 commit intobridgedb:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the BridgeDbConfig plugin currently imports org.pathvisio.core.debug.Logger which doesn't exist in the pathvisio4 repository. The class is moved to org.pathvisio.libgpml.debug.Logger.
This was causing a compilation error from my side while building the plugin in PathVisio4.
I updated the logger import in the following files:
BridgeDbConfigPlugin.java
BridgeDbConfigDlg.java
IdMapperDlg.java
This is only an import path change with no logic modifications whatsoever.
I tested it by building the plugin in pathvisio4-ant and the plugin loads successfully without any error.
@egonw @DeniseSl22
Looking forward to your review!