[codex] Add conversation memory ingest#32
Conversation
5722c94 to
a85d361
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5722c94dff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if not isinstance(raw_turn, dict): | ||
| raise ValueError(f"turns[{index}] must be an object") | ||
|
|
||
| raw_content = raw_turn.get("content", raw_turn.get("text")) |
There was a problem hiding this comment.
Fall back to
text when content is blank
Treating content as authoritative via raw_turn.get("content", raw_turn.get("text")) rejects valid turns when clients send both fields but leave content empty (for example, serializers that always include it) while populating text. In that case normalize_conversation_turns raises INVALID_INPUT and the entire memory_add_conversation call fails, even though the payload satisfies the documented "content or text" contract.
Useful? React with 👍 / 👎.
Summary
Validation
Notes