Skip to content

[codex] Add conversation memory ingest#32

Merged
brianmeyer merged 1 commit into
masterfrom
codex/rec-75-conversation-memories
May 17, 2026
Merged

[codex] Add conversation memory ingest#32
brianmeyer merged 1 commit into
masterfrom
codex/rec-75-conversation-memories

Conversation

@brianmeyer
Copy link
Copy Markdown
Owner

Summary

  • add first-class conversation memory helpers plus storage indexing for root conversation memories and per-turn child memories
  • expose memory_add_conversation over MCP and include memory evidence paths in search/search_batch responses
  • update docs/UAT coverage for the expanded 24-tool MCP surface and conversation rollups

Validation

  • python3 -m pytest -q
  • bash tests/uat/test_mcp_server.sh
  • python3 -m compileall -q src tests
  • .venv/bin/python -m pip wheel . -w /tmp/recallforge-wheel-rec75

Notes

  • .venv lacks twine and executable build module locally, so twine check/python -m build could not be run here. The wheel build succeeded through pip's PEP 517 path.

@brianmeyer brianmeyer force-pushed the codex/rec-75-conversation-memories branch from 5722c94 to a85d361 Compare May 17, 2026 19:06
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5722c94dff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if not isinstance(raw_turn, dict):
raise ValueError(f"turns[{index}] must be an object")

raw_content = raw_turn.get("content", raw_turn.get("text"))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fall back to text when content is blank

Treating content as authoritative via raw_turn.get("content", raw_turn.get("text")) rejects valid turns when clients send both fields but leave content empty (for example, serializers that always include it) while populating text. In that case normalize_conversation_turns raises INVALID_INPUT and the entire memory_add_conversation call fails, even though the payload satisfies the documented "content or text" contract.

Useful? React with 👍 / 👎.

@brianmeyer brianmeyer merged commit d0875cd into master May 17, 2026
4 checks passed
@brianmeyer brianmeyer deleted the codex/rec-75-conversation-memories branch May 17, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant