Update select placeholder tests#1
Open
radium-v wants to merge 2 commits into
Open
Conversation
radium-v
commented
Jan 6, 2024
| }); | ||
|
|
||
| await expect(element).toHaveJSProperty("value", ""); | ||
| await expect(element).not.hasAttribute("value"); |
Author
There was a problem hiding this comment.
This hasAttribute assertion is custom-made to work around a Playwright bug with empty attributes. It's been fixed in recent versions of Playwright, so I'll set this back to toHaveAttribute in microsoft#6876.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
This PR updates the tests to use
Locatorobjects and fixes some assertions. It also removes theapi-report.mdchange which was preventing the actions from running in microsoft#6854.