chore(flake8): address outstanding linting#245
Closed
layertwo wants to merge 1 commit intobrian7704:masterfrom
Closed
chore(flake8): address outstanding linting#245layertwo wants to merge 1 commit intobrian7704:masterfrom
layertwo wants to merge 1 commit intobrian7704:masterfrom
Conversation
Contributor
Author
|
Can I get a review on this? |
Owner
|
Thanks for the PR. It looks mostly good but it's making a lot of changes that I think could cause some issues and will need extensive testing. Unfortunately I just don't have the time to enumerate and test every potential breaking change so I'm going to have to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #242 where I have run flake8 and addressed the outstanding issues.
If there's anything you see that should be changed, happy to address that. Did my best to keep things if place if there were associated comments indicating that.