fix(functions): reject python bundle paths with whitespace#99
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Open
fix(functions): reject python bundle paths with whitespace#99Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Conversation
Fail fast in bt functions push when a Python source file or package path contains whitespace. These paths cannot be imported safely by the generated register.py entrypoint, which could otherwise allow a successful push and later fail at runtime. Also add regression coverage for filenames with embedded and leading spaces. Refs BT-4686
Abhijeet Prasad (AbhiPrasad)
requested review from
Parker Henderson (parkerhendo) and
ViaDézo1er / cedric (viadezo1er)
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail fast in bt functions push when a Python source file or package path contains whitespace. These paths cannot be imported safely by the generated register.py entrypoint, which could otherwise allow a successful push and later fail at runtime.
Also add regression coverage for filenames with embedded and leading spaces.
ref https://linear.app/braintrustdata/issue/BT-4686/