Open
Conversation
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Nathan Selvidge (nselvidge)
approved these changes
Apr 7, 2026
Contributor
Nathan Selvidge (nselvidge)
left a comment
Nathan Selvidge (nselvidge)
left a comment
There was a problem hiding this comment.
a couple nits but otherwise looks good
| } | ||
|
|
||
| async fn fetch_openapi_spec(source_url: &str) -> Result<String> { | ||
| let response = reqwest::Client::new() |
Contributor
There was a problem hiding this comment.
nit: probably need DEFAULT_HTTP_TIMEOUT here
Comment on lines
+407
to
+410
| return Ok(ResolvedBearerToken { | ||
| token, | ||
| expires_at: None, | ||
| }); |
Contributor
There was a problem hiding this comment.
since this is used in run_token we'll log the permanent BRAINTRUST_API_KEY to stdout. I think that's fine but calling it out.
Parker Henderson (parkerhendo)
approved these changes
Apr 7, 2026
Contributor
Parker Henderson (parkerhendo)
left a comment
Parker Henderson (parkerhendo)
left a comment
There was a problem hiding this comment.
command structure and such look good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.