Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/release-canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BUILD_MANIFEST_NAME: target/distrib/${{ join(matrix.targets, '-') }}-dist-manifest.json
HAS_SSLDOTCOM_SIGNING: ${{ secrets.SSLDOTCOM_USERNAME != '' && secrets.SSLDOTCOM_PASSWORD != '' && secrets.SSLDOTCOM_CREDENTIAL_ID != '' && secrets.SSLDOTCOM_TOTP_SECRET != '' }}
steps:
- name: Enable windows longpaths
run: git config --global core.longpaths true
Expand Down Expand Up @@ -152,6 +153,31 @@ jobs:
- name: Install dependencies
run: ${{ matrix.packages_install }}

- name: Configure SSL.com signing env
if: ${{ runner.os == 'Windows' && env.HAS_SSLDOTCOM_SIGNING == 'true' }}
shell: bash
env:
SSLDOTCOM_USERNAME: ${{ secrets.SSLDOTCOM_USERNAME }}
SSLDOTCOM_PASSWORD: ${{ secrets.SSLDOTCOM_PASSWORD }}
SSLDOTCOM_CREDENTIAL_ID: ${{ secrets.SSLDOTCOM_CREDENTIAL_ID }}
SSLDOTCOM_TOTP_SECRET: ${{ secrets.SSLDOTCOM_TOTP_SECRET }}
run: |
write_github_env() {
local key="$1"
local value="$2"
local delimiter="EOF_${key}_$$"
{
echo "${key}<<${delimiter}"
echo "${value}"
echo "${delimiter}"
} >> "$GITHUB_ENV"
}

write_github_env "SSLDOTCOM_USERNAME" "$SSLDOTCOM_USERNAME"
write_github_env "SSLDOTCOM_PASSWORD" "$SSLDOTCOM_PASSWORD"
write_github_env "SSLDOTCOM_CREDENTIAL_ID" "$SSLDOTCOM_CREDENTIAL_ID"
write_github_env "SSLDOTCOM_TOTP_SECRET" "$SSLDOTCOM_TOTP_SECRET"

- name: Build artifacts
shell: bash
run: |
Expand Down
26 changes: 26 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BUILD_MANIFEST_NAME: target/distrib/${{ join(matrix.targets, '-') }}-dist-manifest.json
HAS_SSLDOTCOM_SIGNING: ${{ secrets.SSLDOTCOM_USERNAME != '' && secrets.SSLDOTCOM_PASSWORD != '' && secrets.SSLDOTCOM_CREDENTIAL_ID != '' && secrets.SSLDOTCOM_TOTP_SECRET != '' }}
steps:
- name: Enable windows longpaths
run: git config --global core.longpaths true
Expand Down Expand Up @@ -137,6 +138,31 @@ jobs:
- name: Install dependencies
run: ${{ matrix.packages_install }}

- name: Configure SSL.com signing env
if: ${{ runner.os == 'Windows' && env.HAS_SSLDOTCOM_SIGNING == 'true' }}
shell: bash
env:
SSLDOTCOM_USERNAME: ${{ secrets.SSLDOTCOM_USERNAME }}
SSLDOTCOM_PASSWORD: ${{ secrets.SSLDOTCOM_PASSWORD }}
SSLDOTCOM_CREDENTIAL_ID: ${{ secrets.SSLDOTCOM_CREDENTIAL_ID }}
SSLDOTCOM_TOTP_SECRET: ${{ secrets.SSLDOTCOM_TOTP_SECRET }}
run: |
write_github_env() {
local key="$1"
local value="$2"
local delimiter="EOF_${key}_$$"
{
echo "${key}<<${delimiter}"
echo "${value}"
echo "${delimiter}"
} >> "$GITHUB_ENV"
}

write_github_env "SSLDOTCOM_USERNAME" "$SSLDOTCOM_USERNAME"
write_github_env "SSLDOTCOM_PASSWORD" "$SSLDOTCOM_PASSWORD"
write_github_env "SSLDOTCOM_CREDENTIAL_ID" "$SSLDOTCOM_CREDENTIAL_ID"
write_github_env "SSLDOTCOM_TOTP_SECRET" "$SSLDOTCOM_TOTP_SECRET"

- name: Build artifacts
shell: bash
run: |
Expand Down
11 changes: 11 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,14 @@ Notes:

- The workflow publishes an immutable tag: `canary-<branch-slug>-<short-sha>`.
- It also updates a moving branch tag: `canary-<branch-slug>` when the run is for the latest commit on that branch.

## Windows Release Signing

Release and canary workflows can Authenticode-sign Windows artifacts when these GitHub Actions repository secrets are configured:

- `SSLDOTCOM_USERNAME`
- `SSLDOTCOM_PASSWORD`
- `SSLDOTCOM_CREDENTIAL_ID`
- `SSLDOTCOM_TOTP_SECRET`

If those secrets are absent, `cargo-dist` skips Windows signing and the published `bt.exe` remains unsigned.
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ ci = "github"
create-release = true
pr-run-mode = "plan"
allow-dirty = ["ci"]
ssldotcom-windows-sign = "prod"

[package.metadata.dist]
installers = ["shell", "powershell"]
Expand Down
Loading