fix(claude_agent_sdk): use result message output#218
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Open
fix(claude_agent_sdk): use result message output#218Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Conversation
Prefer ResultMessage.result as the root Claude Agent task output when the SDK provides it. The streamed assistant message can differ from the canonical final result, so the integration now records the final result value on the root span and falls back to the accumulated assistant content only when no result field is present. Also tighten the existing cassette-backed calculator test to assert the root task output matches the result message.
Abhijeet Prasad (AbhiPrasad)
requested a review
from ViaDézo1er / cedric (viadezo1er)
|
Drop into this review session: No serious bugs or issues found 🎉 |
Luca Forstner (lforst)
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer ResultMessage.result as the root Claude Agent task output when the SDK provides it. The streamed assistant message can differ from the canonical final result, so the integration now records the final result value on the root span and falls back to the accumulated assistant content only when no result field is present.
Also tighten the existing cassette-backed calculator test to assert the root task output matches the result message.
ref #149