feat(claude_agent_sdk): trace top-level query calls#216
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intomainfrom Apr 7, 2026
Merged
feat(claude_agent_sdk): trace top-level query calls#216Abhijeet Prasad (AbhiPrasad) merged 1 commit intomainfrom
Abhijeet Prasad (AbhiPrasad) merged 1 commit intomainfrom
Conversation
Patch the exported claude_agent_sdk.query helper so one-shot queries emit the same task and LLM spans as ClaudeSDKClient. This preserves tracing when callers import query before setup and use the standalone API directly. Refactor prompt capture and streamed message handling into shared helpers so the client and one-shot query paths stay aligned, and add a regression test that fails before the patch and verifies import-before-setup alias propagation.
Abhijeet Prasad (AbhiPrasad)
requested a review
from ViaDézo1er / cedric (viadezo1er)
Abhijeet Prasad (AbhiPrasad)
changed the title
|
Drop into this review session: No serious bugs or issues found 🎉 |
Andrew Kent (realark)
approved these changes
Apr 7, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi-fix-instrument-claude-sdk-query
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch the exported claude_agent_sdk.query helper so one-shot queries emit the same task and LLM spans as ClaudeSDKClient. This preserves tracing when callers import query before setup and use the standalone API directly.
Refactor prompt capture and streamed message handling into shared helpers so the client and one-shot query paths stay aligned, and add a regression test that fails before the patch and verifies import-before-setup alias propagation.
ref #149