feat(google_genai): trace interactions api methods#210
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Open
feat(google_genai): trace interactions api methods#210Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Conversation
Instrument the Google GenAI Interactions API for sync and async create, get, cancel, delete, and streaming calls. The new tracing normalizes interaction inputs and outputs, records usage and timing, tracks previous_interaction_id, and emits nested tool spans for interaction tool calls. Replace the earlier fake-based interaction coverage with VCR-backed integration tests and recorded cassettes so the span shape is validated against real SDK behavior. Closes #198
|
Drop into this review session: No serious bugs or issues found 🎉 |
| } | ||
| ) | ||
|
|
||
| with start_span( |
There was a problem hiding this comment.
might be a dumb question but I am wondering whether we are properly nesting things inside the tool calls within the tool span here? Also are we properly recording start/end timestamps with this?
Luca Forstner (lforst)
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instrument the Google GenAI Interactions API for sync and async create, get, cancel, delete, and streaming calls. The new tracing normalizes interaction inputs and outputs, records usage and timing, tracks previous_interaction_id, and emits nested tool spans for interaction tool calls.
Replace the earlier fake-based interaction coverage with VCR-backed integration tests and recorded cassettes so the span shape is validated against real SDK behavior.
Closes #198