fix: Fix claude agent SDK tool nesting#1755
Merged
Luca Forstner (lforst) merged 4 commits intomainfrom Apr 8, 2026
Merged
Conversation
Abhijeet Prasad (AbhiPrasad)
approved these changes
Apr 8, 2026
| spanAttributes: { | ||
| type: SpanTypeAttribute.LLM, | ||
| }, | ||
| startTime: getCurrentUnixTimestamp(), |
There was a problem hiding this comment.
not sure if this timestamp is correct, isn't that relative to when the tool call ran? And not actually when the llm call itself ran?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1655
Resolves #1658
Fixes claude agent SDK tool nesting by switching from the hook based events (PreToolUse, PostToolUse) that started and ended the span to using AsyncLocalStorage and having proper execution context. For remote tools we are still using the hooks because we don't have any local tools to wrap.